Skip to content

Emit a friendlier warning on invalid exclude regex, instead of a stacktrace #19102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

Emit a friendlier warning on invalid exclude regex, instead of a stacktrace #19102

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c40552e
emit a friendlier warning on invalid exclude regex, instead of a stac…
wyattscarpenter May 17, 2025
3c203aa
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 17, 2025
d0931c3
send errors to stderr
wyattscarpenter May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions mypy/modulefinder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,12 +684,22 @@ def matches_exclude(
if fscache.isdir(subpath):
subpath_str += "/"
for exclude in excludes:
if re.search(exclude, subpath_str):
if verbose:
print(
f"TRACE: Excluding {subpath_str} (matches pattern {exclude})", file=sys.stderr
)
return True
try:
if re.search(exclude, subpath_str):
if verbose:
print(
f"TRACE: Excluding {subpath_str} (matches pattern {exclude})",
file=sys.stderr,
)
return True
except re.error as e:
print(f"error: The exclude {exclude} is an invalid regular expression, because:", e)
if "\\" in exclude:
print("(Hint: use / as a path separator, even if you're on Windows!)")
print(
"For more information on Python's flavor of regex, see: https://docs.python.org/3/library/re.html"
)
sys.exit(2)
return False


Expand Down