Fix properties with setters after deleters #19248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sterliakov
approved these changes
Jun 7, 2025
Collaborator
sterliakov
left a comment
sterliakov
left a comment
There was a problem hiding this comment.
I'm a bit worried that now there's no single "source of truth" for Var.is_settable_property vs Decorator.setter_index, they may eventually get out of sync somewhere. But I can't suggest anything better yet:(
Member
Author
|
Yeah, I was thinking about this myself. Actually since I am not the only one worried, let me add one assert that will make this less likely. |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Closed
JukkaL
pushed a commit
that referenced
this pull request
Jun 11, 2025
Fixes #19224 Note we must add an additional attribute on `OverloadedFuncDef` since decorator expressions are not serialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19224
Note we must add an additional attribute on
OverloadedFuncDefsince decorator expressions are not serialized.