Skip to content

[mypyc] Fix comparison of tuples with different lengths #19372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

[mypyc] Fix comparison of tuples with different lengths #19372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a9c906
Fix comparison of tuples with different lengths
p-sawicki Jul 3, 2025
12f517c
Add more test cases
p-sawicki Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mypyc/irbuild/ll_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,6 +1507,10 @@ def compare_tuples(self, lhs: Value, rhs: Value, op: str, line: int = -1) -> Val
assert isinstance(lhs.type, RTuple) and isinstance(rhs.type, RTuple)
equal = True if op == "==" else False
result = Register(bool_rprimitive)
# tuples of different lengths
if len(lhs.type.types) != len(rhs.type.types):
self.add(Assign(result, self.false() if equal else self.true(), line))
return result
# empty tuples
if len(lhs.type.types) == 0 and len(rhs.type.types) == 0:
self.add(Assign(result, self.true() if equal else self.false(), line))
Expand Down
6 changes: 6 additions & 0 deletions mypyc/test-data/run-tuples.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,12 @@ def f7(x: List[Tuple[int, int]]) -> int:
def test_unbox_tuple() -> None:
assert f7([(5, 6)]) == 11

def test_comparison() -> None:
assert ('x','y') == ('x','y')
assert not(('x','y') != ('x','y'))
assert ('x','y') != ('x','y',1)
assert not(('x','y') == ('x','y',1))

# Test that order is irrelevant to unions. Really I only care that this builds.

class A:
Expand Down