Fix swapping TypeVars with defaults. #19448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
randolf-scholz
commented
Jul 15, 2025
Comment on lines
+251
to
+254
| if isinstance(expanded, TypeVarType): | ||
| expanded.default = expanded.default.accept(self) | ||
| else: | ||
| repl = expanded |
Contributor
Author
There was a problem hiding this comment.
maybe more readable if done the other way round?
expanded = repl.accept(self)
if not isinstance(expanded, TypeVarType):
repl = expanded
else:
expanded.default = expanded.default.accept(self)
ilevkivskyi
pushed a commit
that referenced
this pull request
Oct 27, 2025
- Fixes #19444. (added `testTypeVarDefaultsSwap`) - Fixes #19362 (added `testTypeVarDefaultsSwap2`) Changed the logic for recursion guards of `TypeVarType`: Instead of always substituting `repl = repl.accept(self)`, and situationally updating `repl.default = repl.default.accept(self)` if the result is a `TypeVarType`, we now always update `repl.default = repl.default.accept(self)` a priori and then only choose the expanded `repl.accept(self)` if the result is a concrete type. ## New Tests - `testTypeVarDefaultsSwap` (https://mypy-play.net/?mypy=1.17.0&python=3.12&gist=d5a025a31ae3c8b9e2a36f4738aa1991) - `testTypeVarDefaultsSwap2` (https://mypy-play.net/?mypy=1.17.0&python=3.12&gist=d3ed42c82f7144967c97d846c4c041ef) PS: closed earlier PRs #19447, since it contained debugging changes, and #19448 because it didn't solve #19362.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testTypeVarDefaultsSwapMy idea is that we should only return the result of
repl = repl.accept(self)if that result is no longer aTypeVarType, because if we are simply permuting the type variables, then this will be incorrect.