-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Better support for SomeEnum.item == some_literal
#19594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sterliakov
wants to merge
13
commits into
python:master
Choose a base branch
from
sterliakov:bugfix/gh-19576-enum-comparison-overlap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+373
−9
Draft
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ab3ed33
Fix enum comparison with literal values
sterliakov 6f4dbb8
Merge remote-tracking branch 'upstream/master' into bugfix/gh-19576-e…
sterliakov 350aa53
Sync reachability and comparison overlap checks
sterliakov ebfc647
Fix selfcheck
sterliakov 0001936
Oops
sterliakov c87c707
Prevent narrowing by equality to overlapping literals (discarding enu…
sterliakov ba560f2
No, that was too much
sterliakov d96243d
Pick unreachable branches more aggressively
sterliakov 6c4f0aa
Merge remote-tracking branch 'upstream/master' into bugfix/gh-19576-e…
sterliakov 79262e7
Handle (str, Enum) and (int, Enum) subclasses narrowing
sterliakov 9fda66e
Merge branch 'master' into bugfix/gh-19576-enum-comparison-overlap
sterliakov b3713a2
Merge branch 'master' into bugfix/gh-19576-enum-comparison-overlap
sterliakov 0017943
Merge branch 'master' into bugfix/gh-19576-enum-comparison-overlap
sterliakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.