[mypyc] feat: extend stararg fastpath from #19623 to handle lists and generic sequences #19629
+325
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobTheBuidler
added a commit
to BobTheBuidler/mypy
that referenced
this pull request
Aug 9, 2025
This was referenced Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #19623 with additional logic for handling non-tuple star inputs
Now, we can use the fast path for any arbitrary sequence, in addition to tuples.
I opted to separate this PR from 19623 to keep them smaller and easier to review, and to declutter the changes in the IR.
This PR is ready for review (after #19623 is reviewed and merged)