Fix spurious possibly-undefined errors in for-else with break #19696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a for loop contains branches with `break` and an `else` block, variables declared inside those branches were incorrectly discarded from further analysis, leading Mypy to incorrectly report a variable as undefined after the loop or as used before declaration. With this fix, when a for loop's `else` block is considered, variables declared in every branch of the `for` loop body that called `break` are now considered as defined within the body of the loop. Fixes python#14209 Fixes python#19690
for more information, see https://pre-commit.ci
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
Author
|
@ilevkivskyi, I asked you for review since you reviewed the original change three years back. |
ilevkivskyi
approved these changes
Aug 25, 2025
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
TBH I forget many details since I last looked at this code, bu this looks reasonable. I just have a test suggestion.
| else: | ||
| raise RuntimeError | ||
|
|
||
| print(value) # Should not error - value is defined if we broke |
Member
There was a problem hiding this comment.
Maybe also add one two tests where it should error? Like, e.g, if raise above is conditional.
Contributor
Author
There was a problem hiding this comment.
Good idea, I will add the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a for loop contains branches with
breakand anelseblock, variables declared inside those branches were incorrectly discarded from further analysis, leading Mypy to incorrectly report a variable as undefined after the loop or as used before declaration.With this fix, when a for loop's
elseblock is considered, variables declared in every branch of theforloop body that calledbreakare now considered as defined within the body of the loop.Fixes #14209
Fixes #19690