Add --color-output=force that colors output regardless if it is going to a terminal
#19703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…t/mypy into color-output-option
for more information, see https://pre-commit.ci
…t/mypy into color-output-option
for more information, see https://pre-commit.ci
FORCE_COLOR may impact other tools but I'll give it a try anyway ...
…t/mypy into color-output-option
…t/mypy into color-output-option
for more information, see https://pre-commit.ci
…t/mypy into color-output-option
for more information, see https://pre-commit.ci
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18746
Based on feedback of PR #19685, add
--color-output=force, leaving behavior of--color-outputunchanged.Also document
MYPY_FORCE_COLORandFORCE_COLOR.A breaking change is that
FORCE_COLORnow takes precedence over--no-color-output, enabling color. Previously, color is disabled when both are present. Let me know what you think about it (should I preserve old behavior?).