Skip to content

[stubtest] temporary --ignore-disjoint-bases flag #19740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

[stubtest] temporary --ignore-disjoint-bases flag #19740

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c69535
stubtest: temporary `--ignore-disjoint-bases` flag
jorenham Aug 26, 2025
1abe75e
stubtest: make the `--ignore-disjoint-bases` hack less inconsistent
jorenham Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion mypy/stubtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,11 @@ def verify_typeinfo(
return

yield from _verify_final(stub, runtime, object_path)
yield from _verify_disjoint_base(stub, runtime, object_path)

# TODO: Once PEP 800 gets accepted, remove the conditional (always verify)
if "--ignore-disjoint-bases" not in sys.argv[1:]:
yield from _verify_disjoint_base(stub, runtime, object_path)

is_runtime_typeddict = stub.typeddict_type is not None and is_typeddict(runtime)
yield from _verify_metaclass(
stub, runtime, object_path, is_runtime_typeddict=is_runtime_typeddict
Expand Down Expand Up @@ -2364,6 +2368,12 @@ def parse_options(args: list[str]) -> _Arguments:
action="store_true",
help="Ignore errors for whether an argument should or shouldn't be positional-only",
)
# TODO: Remove once PEP 800 is accepted
parser.add_argument(
"--ignore-disjoint-bases",
action="store_true",
help="Disable checks for PEP 800 @disjoint_base classes",
)
parser.add_argument(
"--allowlist",
"--whitelist",
Expand Down
Loading