[mypyc] Refactor IR build of equality and unary operators #19756
+76
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-sawicki
approved these changes
Aug 29, 2025
Collaborator
p-sawicki
left a comment
p-sawicki
left a comment
There was a problem hiding this comment.
looks good, one small nit
mypyc/irbuild/ll_builder.py
Outdated
Comment on lines
1664
to
1665
| mask = Integer(1, value.type, line) | ||
| return self.int_op(value.type, value, mask, IntOp.XOR, line) |
Collaborator
There was a problem hiding this comment.
could use typ in place of value.type here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the code cleaner. This will also make it easier to implement additional optimizations.
This probably fixes a few bugs as well.