[mypyc] feat: constant folding for DictExpr [1/1] #19864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…into dict-literals
for more information, see https://pre-commit.ci
…into dict-literals
BobTheBuidler
commented
Sep 17, 2025
|
|
||
| # Supported Python literal types. All tuple / frozenset items must have supported | ||
| # Supported Python literal types. All tuple / frozenset / dict items must have supported | ||
| # literal types as well, but we can't represent the type precisely. |
There was a problem hiding this comment.
is there a reason we can't represent the type precisely? I think with a HashableLiteralValue defined before LiteralValue, we can do it pretty cleanly
for more information, see https://pre-commit.ci
…into dict-literals
for more information, see https://pre-commit.ci
…into dict-literals
unsupported operand type(s) for |: '_UnionGenericAlias' and 'types.GenericAlias'
BobTheBuidler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to "constant fold" a LOC such as:
We can't simply create a dictionary constant since dicts are mutable and we don't know what's going to happen in the called function, but we can hold a template dict in memory and PyDict_Copy it when it's time for use. This skips the hashing and any resizing during construction, and simply takes the hash table from the existing dict instead, which will be (possibly much) quicker than constructing from scratch each time.
This PR does that.