[mypyc] feat: cache ids for fallback pythonic method lookups [1/1] #19870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR microoptimizes the usage of
_Py_IDENTIFIERand_PyUnicode_FromIdin various C files.Changes:
setdefault,update,keys,values,items,clear,copy), a static cache variable (e.g.,setdefault_id_unicode) is used to store the result of_PyUnicode_FromId._Py_IDENTIFIER(name)macro is now declared only inside the conditional block that runs the first time a function is called (i.e., when the corresponding cache variable isNULL)._PyUnicode_FromIdand repeated static identifier declarations.Example pattern after refactor: