-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Mention what codes are actually ignored in not covered by "type: ignore" comment
note
#19904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wyattscarpenter
wants to merge
5
commits into
python:master
Choose a base branch
from
wyattscarpenter:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
A5rocks
reviewed
Sep 24, 2025
A5rocks
approved these changes
Sep 24, 2025
wyattscarpenter
commented
Sep 24, 2025
Diff from mypy_primer, showing the effect of this PR on open source code: spack (https://github.com/spack/spack)
- lib/spack/spack/database.py:1762: note: Error code "call-arg" not covered by "type: ignore" comment
+ lib/spack/spack/database.py:1762: note: Error code "call-arg" not covered by "type: ignore[call-overload]" comment
- lib/spack/spack/solver/asp.py:3083: note: Error code "call-arg" not covered by "type: ignore" comment
+ lib/spack/spack/solver/asp.py:3083: note: Error code "call-arg" not covered by "type: ignore[call-overload]" comment
spark (https://github.com/apache/spark)
- python/pyspark/pandas/frame.py:3187: note: Error code "call-overload" not covered by "type: ignore" comment
+ python/pyspark/pandas/frame.py:3187: note: Error code "call-overload" not covered by "type: ignore[arg-type]" comment
- python/pyspark/pandas/frame.py:3205: note: Error code "call-overload" not covered by "type: ignore" comment
+ python/pyspark/pandas/frame.py:3205: note: Error code "call-overload" not covered by "type: ignore[arg-type]" comment
- python/pyspark/pandas/groupby.py:48: note: Error code "import-not-found" not covered by "type: ignore" comment
+ python/pyspark/pandas/groupby.py:48: note: Error code "import-not-found" not covered by "type: ignore[attr-defined]" comment
- python/pyspark/pandas/plot/matplotlib.py:28: note: Error code "import-not-found" not covered by "type: ignore" comment
+ python/pyspark/pandas/plot/matplotlib.py:28: note: Error code "import-not-found" not covered by "type: ignore[attr-defined]" comment
- python/pyspark/pandas/testing.py:241: note: Error code "call-overload" not covered by "type: ignore" comment
+ python/pyspark/pandas/testing.py:241: note: Error code "call-overload" not covered by "type: ignore[call-arg]" comment
prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/utilities/annotations.py:50: note: Error code "valid-type" not covered by "type: ignore" comment
+ src/prefect/utilities/annotations.py:50: note: Error code "valid-type" not covered by "type: ignore[override]" comment
- src/prefect/flows.py:1739: note: Error code "misc" not covered by "type: ignore" comment
+ src/prefect/flows.py:1739: note: Error code "misc" not covered by "type: ignore[reportGeneralTypeIssues]" comment
- src/prefect/task_engine.py:416: note: Error code "call-overload" not covered by "type: ignore" comment
+ src/prefect/task_engine.py:416: note: Error code "call-overload" not covered by "type: ignore[reportCallIssue]" comment
mongo-python-driver (https://github.com/mongodb/mongo-python-driver)
- pymongo/compression_support.py:29: note: Error code "import-not-found" not covered by "type: ignore" comment
+ pymongo/compression_support.py:29: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
- pymongo/encryption_options.py:26: note: Error code "import-not-found" not covered by "type: ignore" comment
+ pymongo/encryption_options.py:26: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
pydantic (https://github.com/pydantic/pydantic)
- pydantic/v1/networks.py:237: note: Error code "typeddict-item" not covered by "type: ignore" comment
+ pydantic/v1/networks.py:237: note: Error code "typeddict-item" not covered by "type: ignore[misc]" comment
pylox (https://github.com/sco1/pylox)
- pylox/ast_printer.py:17: note: Error code "arg-type" not covered by "type: ignore" comment
+ pylox/ast_printer.py:17: note: Error code "arg-type" not covered by "type: ignore[no-any-return]" comment
meson (https://github.com/mesonbuild/meson)
- docs/refman/loaderyaml.py:33:1: note: Error code "import-not-found" not covered by "type: ignore" comment
+ docs/refman/loaderyaml.py:33:1: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
strawberry (https://github.com/strawberry-graphql/strawberry)
- strawberry/experimental/pydantic/_compat.py:307: note: Error code "import-not-found" not covered by "type: ignore" comment
+ strawberry/experimental/pydantic/_compat.py:307: note: Error code "import-not-found" not covered by "type: ignore[no-redef]" comment
- strawberry/experimental/pydantic/_compat.py:313: note: Error code "import-not-found" not covered by "type: ignore" comment
+ strawberry/experimental/pydantic/_compat.py:313: note: Error code "import-not-found" not covered by "type: ignore[no-redef]" comment
sphinx (https://github.com/sphinx-doc/sphinx)
- sphinx/util/docutils.py:437:24: note: Error code "type-arg" not covered by "type: ignore" comment
+ sphinx/util/docutils.py:437:24: note: Error code "type-arg" not covered by "type: ignore[arg-type]" comment
- sphinx/directives/admonitions.py:30:5: note: Error code "misc" not covered by "type: ignore" comment
+ sphinx/directives/admonitions.py:30:5: note: Error code "misc" not covered by "type: ignore[union-attr]" comment
urllib3 (https://github.com/urllib3/urllib3)
- src/urllib3/util/ssl_.py:139: note: Error code "misc" not covered by "type: ignore" comment
+ src/urllib3/util/ssl_.py:139: note: Error code "misc" not covered by "type: ignore[assignment]" comment
- src/urllib3/util/ssl_.py:140: note: Error code "misc" not covered by "type: ignore" comment
+ src/urllib3/util/ssl_.py:140: note: Error code "misc" not covered by "type: ignore[assignment]" comment
- src/urllib3/util/ssl_.py:141: note: Error code "misc" not covered by "type: ignore" comment
+ src/urllib3/util/ssl_.py:141: note: Error code "misc" not covered by "type: ignore[assignment]" comment
- src/urllib3/util/ssl_.py:142: note: Error code "misc" not covered by "type: ignore" comment
+ src/urllib3/util/ssl_.py:142: note: Error code "misc" not covered by "type: ignore[assignment]" comment
- src/urllib3/util/ssl_.py:143: note: Error code "misc" not covered by "type: ignore" comment
+ src/urllib3/util/ssl_.py:143: note: Error code "misc" not covered by "type: ignore[assignment]" comment
- src/urllib3/util/ssl_.py:144: note: Error code "misc" not covered by "type: ignore" comment
+ src/urllib3/util/ssl_.py:144: note: Error code "misc" not covered by "type: ignore[assignment]" comment
- src/urllib3/util/ssl_.py:146: note: Error code "misc" not covered by "type: ignore" comment
+ src/urllib3/util/ssl_.py:146: note: Error code "misc" not covered by "type: ignore[assignment]" comment
- src/urllib3/http2/connection.py:9: note: Error code "import-not-found" not covered by "type: ignore" comment
+ src/urllib3/http2/connection.py:9: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
- src/urllib3/http2/connection.py:10: note: Error code "import-not-found" not covered by "type: ignore" comment
+ src/urllib3/http2/connection.py:10: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
- src/urllib3/http2/connection.py:11: note: Error code "import-not-found" not covered by "type: ignore" comment
+ src/urllib3/http2/connection.py:11: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
- src/urllib3/contrib/socks.py:44: note: Error code "import-untyped" not covered by "type: ignore" comment
+ src/urllib3/contrib/socks.py:44: note: Error code "import-untyped" not covered by "type: ignore[import-not-found]" comment
- src/urllib3/contrib/pyopenssl.py:43: note: Error code "import-not-found" not covered by "type: ignore" comment
+ src/urllib3/contrib/pyopenssl.py:43: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
- src/urllib3/contrib/pyopenssl.py:64: note: Error code "import-not-found" not covered by "type: ignore" comment
+ src/urllib3/contrib/pyopenssl.py:64: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
- test/test_response.py:743: note: Error code "type-var" not covered by "type: ignore" comment
+ test/test_response.py:743: note: Error code "type-var" not covered by "type: ignore[arg-type]" comment
- test/test_response.py:755: note: Error code "type-var" not covered by "type: ignore" comment
+ test/test_response.py:755: note: Error code "type-var" not covered by "type: ignore[arg-type]" comment
- test/test_response.py:760: note: Error code "type-var" not covered by "type: ignore" comment
+ test/test_response.py:760: note: Error code "type-var" not covered by "type: ignore[arg-type]" comment
- test/test_response.py:773: note: Error code "type-var" not covered by "type: ignore" comment
+ test/test_response.py:773: note: Error code "type-var" not covered by "type: ignore[arg-type]" comment
- test/contrib/test_socks.py:12: note: Error code "import-untyped" not covered by "type: ignore" comment
+ test/contrib/test_socks.py:12: note: Error code "import-untyped" not covered by "type: ignore[import-not-found]" comment
- test/contrib/test_pyopenssl.py:10: note: Error code "import-not-found" not covered by "type: ignore" comment
+ test/contrib/test_pyopenssl.py:10: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
pandas (https://github.com/pandas-dev/pandas)
- pandas/io/pytables.py:3309: note: Error code "attr-defined" not covered by "type: ignore" comment
+ pandas/io/pytables.py:3309: note: Error code "attr-defined" not covered by "type: ignore[union-attr]" comment
- pandas/io/pytables.py:3315: note: Error code "attr-defined" not covered by "type: ignore" comment
+ pandas/io/pytables.py:3315: note: Error code "attr-defined" not covered by "type: ignore[union-attr]" comment
dd-trace-py (https://github.com/DataDog/dd-trace-py)
- ddtrace/appsec/_iast/_handlers.py:30: note: Error code "attr-defined" not covered by "type: ignore" comment
+ ddtrace/appsec/_iast/_handlers.py:30: note: Error code "attr-defined" not covered by "type: ignore[no-redef]" comment
werkzeug (https://github.com/pallets/werkzeug)
- src/werkzeug/datastructures/mixins.py:280: note: Error code "assignment" not covered by "type: ignore" comment
+ src/werkzeug/datastructures/mixins.py:280: note: Error code "assignment" not covered by "type: ignore[arg-type]" comment
- src/werkzeug/datastructures/structures.py:711: note: Error code "misc" not covered by "type: ignore" comment
+ src/werkzeug/datastructures/structures.py:711: note: Error code "misc" not covered by "type: ignore[arg-type, attr-defined]" comment
scipy (https://github.com/scipy/scipy)
- scipy/_lib/_testutils.py:21: note: Error code "import-not-found" not covered by "type: ignore" comment
+ scipy/_lib/_testutils.py:21: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
- scipy/_lib/_testutils.py:22: note: Error code "import-not-found" not covered by "type: ignore" comment
+ scipy/_lib/_testutils.py:22: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
pandera (https://github.com/pandera-dev/pandera)
- pandera/engines/pandas_engine.py:1386: note: Error code "return-value" not covered by "type: ignore" comment
+ pandera/engines/pandas_engine.py:1386: note: Error code "return-value" not covered by "type: ignore[operator]" comment
- pandera/strategies/pandas_strategies.py:68: note: Error code "call-overload" not covered by "type: ignore" comment
+ pandera/strategies/pandas_strategies.py:68: note: Error code "call-overload" not covered by "type: ignore[union-attr, arg-type]" comment
- pandera/strategies/pandas_strategies.py:70: note: Error code "call-overload" not covered by "type: ignore" comment
+ pandera/strategies/pandas_strategies.py:70: note: Error code "call-overload" not covered by "type: ignore[union-attr, arg-type]" comment
- pandera/strategies/pandas_strategies.py:71: note: Error code "call-overload" not covered by "type: ignore" comment
+ pandera/strategies/pandas_strategies.py:71: note: Error code "call-overload" not covered by "type: ignore[union-attr]" comment
- tests/dask/test_dask.py:31: note: Error code "operator" not covered by "type: ignore" comment
+ tests/dask/test_dask.py:31: note: Error code "operator" not covered by "type: ignore[attr-defined]" comment
- tests/dask/test_dask.py:36: note: Error code "operator" not covered by "type: ignore" comment
+ tests/dask/test_dask.py:36: note: Error code "operator" not covered by "type: ignore[attr-defined]" comment
- tests/dask/test_dask.py:41: note: Error code "operator" not covered by "type: ignore" comment
+ tests/dask/test_dask.py:41: note: Error code "operator" not covered by "type: ignore[attr-defined]" comment
pwndbg (https://github.com/pwndbg/pwndbg)
- pwndbg/lib/zig.py:93: note: Error code "import-not-found" not covered by "type: ignore" comment
+ pwndbg/lib/zig.py:93: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
- pwndbg/dbg/gdb/symbol.py:188: note: Error code "misc" not covered by "type: ignore" comment
+ pwndbg/dbg/gdb/symbol.py:188: note: Error code "misc" not covered by "type: ignore[attr-defined]" comment
- pwndbg/dbg/lldb/repl/__init__.py:882: note: Error code "import-not-found" not covered by "type: ignore" comment
+ pwndbg/dbg/lldb/repl/__init__.py:882: note: Error code "import-not-found" not covered by "type: ignore[import-untyped]" comment
scipy-stubs (https://github.com/scipy/scipy-stubs)
- tests/cluster/test_vq.pyi:23: note: Error code "attr-defined" not covered by "type: ignore" comment
+ tests/cluster/test_vq.pyi:23: note: Error code "attr-defined" not covered by "type: ignore[arg-type]" comment
- tests/cluster/test_vq.pyi:27: note: Error code "attr-defined" not covered by "type: ignore" comment
+ tests/cluster/test_vq.pyi:27: note: Error code "attr-defined" not covered by "type: ignore[arg-type]" comment
- tests/cluster/test_vq.pyi:34: note: Error code "attr-defined" not covered by "type: ignore" comment
+ tests/cluster/test_vq.pyi:34: note: Error code "attr-defined" not covered by "type: ignore[arg-type]" comment
- tests/cluster/test_vq.pyi:37: note: Error code "attr-defined" not covered by "type: ignore" comment
+ tests/cluster/test_vq.pyi:37: note: Error code "attr-defined" not covered by "type: ignore[arg-type]" comment
- tests/cluster/test_vq.pyi:41: note: Error code "attr-defined" not covered by "type: ignore" comment
+ tests/cluster/test_vq.pyi:41: note: Error code "attr-defined" not covered by "type: ignore[arg-type]" comment
- tests/cluster/test_vq.pyi:44: note: Error code "attr-defined" not covered by "type: ignore" comment
+ tests/cluster/test_vq.pyi:44: note: Error code "attr-defined" not covered by "type: ignore[arg-type]" comment
- tests/cluster/test_vq.pyi:48: note: Error code "attr-defined" not covered by "type: ignore" comment
+ tests/cluster/test_vq.pyi:48: note: Error code "attr-defined" not covered by "type: ignore[arg-type]" comment
- tests/misc/test_submodules_empty.pyi:2: note: Error code "import-untyped" not covered by "type: ignore" comment
+ tests/misc/test_submodules_empty.pyi:2: note: Error code "import-untyped" not covered by "type: ignore[import-not-found]" comment
artigraph (https://github.com/artigraph/artigraph)
- tests/arti/types/test_python_adapters.py:137: note: Error code "arg-type" not covered by "type: ignore" comment
+ tests/arti/types/test_python_adapters.py:137: note: Error code "arg-type" not covered by "type: ignore[operator]" comment
- tests/arti/producers/test_producer.py:619: note: Error code "call-overload" not covered by "type: ignore" comment
+ tests/arti/producers/test_producer.py:619: note: Error code "call-overload" not covered by "type: ignore[arg-type]" comment
- tests/arti/producers/test_producer.py:623: note: Error code "call-overload" not covered by "type: ignore" comment
+ tests/arti/producers/test_producer.py:623: note: Error code "call-overload" not covered by "type: ignore[arg-type]" comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow the user to more easily compare what is already there; especially if pretty is off, such as in mypy_primer diffs.