[mypyc] feat: extend get_expr_length for enumerate, map, zip, range, list, tuple, sorted, and reversed CallExpr [3/4]
#19927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is pretty simple, I just extended get_expr_length to work for a few more obvious cases: - `builtins.enumerate` - `builtins.map` - `builtins.zip` - `builtins.range` This PR is ready for review. Are you going to want tests for all of these? I don't want to spend time now until I know for sure.
for more information, see https://pre-commit.ci
BobTheBuidler
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
BobTheBuidler
changed the title
get_expr_length for enumerate, map, zip, range, list, tuple, sorted, and reversed CallExpr
|
I added an IR test that covers a few of these, and I learned we need to merge #19935 before we can use it how I intended for the test. For now I'm leaving the test in just so it can be compared to #19935 The IR in #19935 is much cleaner, you'll see a r1 = PyTuple_New(5) which shows that the code from the PR did its job. |
TeamSpen210
reviewed
Sep 26, 2025
for more information, see https://pre-commit.ci
BobTheBuidler
changed the title
get_expr_length for enumerate, map, zip, range, list, tuple, sorted, and reversed CallExprget_expr_length for enumerate, map, zip, range, list, tuple, sorted, and reversed CallExpr [3/4]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is pretty simple, I just extended get_expr_length to work for a few more obvious cases:
builtins.enumeratebuiltins.mapbuiltins.zipbuiltins.rangebuiltins.listbuiltins.tuplebuiltins.sortedbuiltins.reversedThis PR is ready for review. Are you going to want tests for all of these? I didn't want to spend time now until I know for sure.
All of the
get_expr_lengthPRs are entirely independent and can be reviewed/merged in any order.