[mypyc] feat: extend get_expr_length to work with RTuple and TupleType [2/4]
#19929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
BobTheBuidler
changed the title
get_expr_length to work with RTuple and TupleType
Contributor
Author
|
If we merge #19931 first, this PR will be reflected in a change to its IR test data |
BobTheBuidler
changed the title
get_expr_length to work with RTuple and TupleTypeget_expr_length to work with RTuple and TupleType [2/4]
BobTheBuidler
commented
Oct 1, 2025
mypyc/irbuild/for_helpers.py
Outdated
| rtype = builder.node_type(expr) | ||
| if isinstance(rtype, RTuple): | ||
| return len(rtype.types) | ||
| proper_type = get_proper_type(builder.types[expr]) |
Contributor
Author
There was a problem hiding this comment.
Do we need this or will the check above it catch every case?
Collaborator
There was a problem hiding this comment.
This check is redundant. If this would be required for some unexpected reason, the issue should be fixed in node_type instead of here, since it would likely affect other things as well. Can you remove the second check?
JukkaL
reviewed
Oct 13, 2025
| r4 = box(int, r1) | ||
| r5 = box(int, r2) | ||
| r6 = box(int, r3) | ||
| r7 = PyTuple_Pack(3, r4, r5, r6) |
Collaborator
There was a problem hiding this comment.
Nice, the new IR is much more efficient!
JukkaL
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
get_expr_lengthto work with type information from RTuple and TupleType classesAll of the
get_expr_lengthPRs are entirely independent and can be reviewed/merged in any order.