[mypyc] feat: extend get_expr_length to try constant_fold_expr [1/4]
#19930
+56
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_expr_len currently support StrExpr, BytesExpr, and string-type Final values constant_fold_expr already has the code to parse values from all of these, so we can deduplicate code by using it It's able to parse a few more Expressions than our existing implementation, and allows get_expr_length to automatically benefit from future constant-folding enhancements
for more information, see https://pre-commit.ci
BobTheBuidler
changed the title
get_expr_len to try constant_fold_exprget_expr_length to try constant_fold_expr
BobTheBuidler
changed the title
get_expr_length to try constant_fold_exprget_expr_length to try constant_fold_expr [review me next plz]
BobTheBuidler
changed the title
get_expr_length to try constant_fold_expr [review me next plz]get_expr_length to try constant_fold_expr [1/4]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other things,
get_expr_lengthcurrently supports StrExpr, BytesExpr, and string-type Final values.constant_fold_expralready has the code to parse values from all of these, so we can use it to deduplicate code inget_expr_length.It's able to parse a few more Expressions than our existing implementation, not that any of these are particularly relevant at the moment, and allows get_expr_length to automatically benefit from more relevant future constant-folding enhancements.
This PR is ready for review. All of the
get_expr_lengthPRs are entirely independent and can be reviewed/merged in any order.