[mypyc] feat: specialize any and all using for loop helpers if possible [1/2]
#19948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
BobTheBuidler
commented
Sep 28, 2025
| r12 = list_get_item_unsafe r2, r9 | ||
| r13 = cast(str, r12) | ||
| __mypyc_any_item__ = r13 | ||
| r14 = CPyStr_IsTrue(__mypyc_any_item__) |
There was a problem hiding this comment.
The boolean check for the any call is now specialized per the dtype of the iterable, and we no longer have to use python's iterator protocol for the input
BobTheBuidler
commented
Sep 28, 2025
| r12 = list_get_item_unsafe r2, r9 | ||
| r13 = cast(str, r12) | ||
| __mypyc_all_item__ = r13 | ||
| r14 = CPyStr_IsTrue(__mypyc_all_item__) |
There was a problem hiding this comment.
The boolean check for the all call is now specialized per the dtype of the iterable, and we no longer have to use python's iterator protocol for the input
This was referenced Sep 29, 2025
BobTheBuidler
commented
Sep 29, 2025
| builder.goto(loop_exit) | ||
| builder.activate_block(true_block) | ||
|
|
||
| index_type = builder._analyze_iterable_item_type(arg) |
There was a problem hiding this comment.
should I deduplicate this block or is this fine?
BobTheBuidler
commented
Sep 29, 2025
|
|
||
| def create_synthetic_nameexpr(index_name: str, index_type: Type) -> NameExpr: | ||
| """This helper spoofs a NameExpr to use as the lvalue in one of the for loop helpers.""" | ||
| index = NameExpr(index_name) |
There was a problem hiding this comment.
I probably need something here to ensure no name collisions globally, but not sure what
BobTheBuidler
changed the title
BobTheBuidler
changed the title
any and all using for loop helpers if possible [1/2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
anyandallcall specializers to use our for loop helpers in cases where they can be used.This is only marginally helpful now but will become more impactful with the addition of
ForMapandForFilterhelpers, as well as any future helpers.While the private helpers might seem unnecessary at this point, I intend to use them for future specialization use cases such as
list(iterable)andtuple(iterable)as discussed in #19649 , andsum(iterable)which will come shortly after this PR.This PR is ready for review
Update: The
sum(iterable)is now ready in #19950. It's a bit more involved than this one so I'm going to leave it separate.Update: The helpers are no longer private