Skip to content

feat: support constant folding in MessageBuilder.incompatible_argument [1/1] #19974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: support constant folding in MessageBuilder.incompatible_argument [1/1] #19974

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
88d5aac
[mypyc] feat: support constant folding in `MessageBuilder.incompatibl…
BobTheBuidler Oct 2, 2025
a2605ad
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 2, 2025
175d5d4
Update messages.py
BobTheBuidler Oct 2, 2025
6c768b1
Merge branch 'master' into constant-fold-invalid-message
BobTheBuidler Oct 2, 2025
df6a4bc
Merge branch 'master' into constant-fold-invalid-message
BobTheBuidler Oct 2, 2025
a88edb2
Merge branch 'master' into constant-fold-invalid-message
BobTheBuidler Oct 4, 2025
5cd93d3
Merge branch 'master' into constant-fold-invalid-message
BobTheBuidler Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mypy/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import mypy.typeops
from mypy import errorcodes as codes, message_registry
from mypy.constant_fold import constant_fold_expr
from mypy.erasetype import erase_type
from mypy.errorcodes import ErrorCode
from mypy.errors import (
Expand Down Expand Up @@ -50,7 +51,6 @@
MypyFile,
NameExpr,
ReturnStmt,
StrExpr,
SymbolNode,
SymbolTable,
TypeInfo,
Expand Down Expand Up @@ -808,10 +808,10 @@ def incompatible_argument(
)
arg_label = f'"{arg_name}"'
if isinstance(outer_context, IndexExpr) and isinstance(
outer_context.index, StrExpr
index := constant_fold_expr(outer_context.index, "<unused>"), str
):
msg = 'Value of "{}" has incompatible type {}; expected {}'.format(
outer_context.index.value,
index,
quote_type_string(arg_type_str),
quote_type_string(expected_type_str),
)
Expand Down