-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Run CI for Python 3.14.0 and free-threading #20029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
attrs>=18.0 | ||
filelock>=3.3.0 | ||
lxml>=5.3.0; python_version<'3.15' | ||
lxml>=5.3.0; python_version<'3.14' # lxml doesn't ship wheels for cp314t yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be updated if PEP 780 get's accepted. It's still a draft though at the moment.
https://peps.python.org/pep-0780/#examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully lxml will have a free-threaded release out soon. My next task today is to run the lxml tests under TSan to hopefully validate a final set of fixes.
This comment has been minimized.
This comment has been minimized.
Looks like there is just one flaky test for the mypy/test/teststubgen.py::StubgenPythonSuite::stubgen.test::testImportedModuleHardExits_import |
91f1414
to
05d345b
Compare
This comment has been minimized.
This comment has been minimized.
05d345b
to
27b04ec
Compare
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Hi! I missed this and opened #20076. I think the failing test in the CI will be fixed when Python 3.14.1 comes out. The issue is fixed in the 3.15, 3.13, and as of yesterday also the 3.14 development branch. The 3.14 release schedule says we might have to wait until December for 3.14.1, so it might make sense to simply skip the failing tests for now. |
I think this makes sense. I'd normally suggest we do a |
Normally I'd agree. However it might be a bit more difficult. AFAICT it's not just one test but up to 5-10 different ones (?) which are failing each time. Not sure I'm comfortable with skipping this many. Yes, December is still two months away, however users are still able to use the pure Python version so there is at least an option for them. Technically they could also compile mypy from the sdist themselves. It might be better to just wait and add the free-threading version then. |
No description provided.