Skip to content

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Oct 8, 2025

No description provided.

This comment has been minimized.

@cdce8p cdce8p changed the title Run CI with Python 3.14.0 final Run CI for Python 3.14.0 and free-threading Oct 8, 2025
attrs>=18.0
filelock>=3.3.0
lxml>=5.3.0; python_version<'3.15'
lxml>=5.3.0; python_version<'3.14' # lxml doesn't ship wheels for cp314t yet
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be updated if PEP 780 get's accepted. It's still a draft though at the moment.
https://peps.python.org/pep-0780/#examples

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully lxml will have a free-threaded release out soon. My next task today is to run the lxml tests under TSan to hopefully validate a final set of fixes.

This comment has been minimized.

@cdce8p
Copy link
Collaborator Author

cdce8p commented Oct 8, 2025

Looks like there is just one flaky test for the free-threading build.

mypy/test/teststubgen.py::StubgenPythonSuite::stubgen.test::testImportedModuleHardExits_import

@cdce8p cdce8p force-pushed the actions-use-3.14.0 branch from 91f1414 to 05d345b Compare October 9, 2025 22:16

This comment has been minimized.

@cdce8p cdce8p force-pushed the actions-use-3.14.0 branch from 05d345b to 27b04ec Compare October 13, 2025 23:37
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@sterliakov sterliakov mentioned this pull request Oct 17, 2025
@ngoldbaum
Copy link

Hi! I missed this and opened #20076. I think the failing test in the CI will be fixed when Python 3.14.1 comes out. The issue is fixed in the 3.15, 3.13, and as of yesterday also the 3.14 development branch.

The 3.14 release schedule says we might have to wait until December for 3.14.1, so it might make sense to simply skip the failing tests for now.

@emmatyping
Copy link
Member

The 3.14 release schedule says we might have to wait until December for 3.14.1, so it might make sense to simply skip the failing tests for now.

I think this makes sense. I'd normally suggest we do a sys.version_info == (3, 14, 0)), but I don't think that can be encoded in our test harness at the moment.

@cdce8p
Copy link
Collaborator Author

cdce8p commented Oct 18, 2025

The 3.14 release schedule says we might have to wait until December for 3.14.1, so it might make sense to simply skip the failing tests for now.

Normally I'd agree. However it might be a bit more difficult. AFAICT it's not just one test but up to 5-10 different ones (?) which are failing each time. Not sure I'm comfortable with skipping this many.

Yes, December is still two months away, however users are still able to use the pure Python version so there is at least an option for them. Technically they could also compile mypy from the sdist themselves. It might be better to just wait and add the free-threading version then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants