Update shellcheck version in actionlint pre-commit to 0.11.0 #20030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting bizarre wasm failures from runtests running pre-commit running actionlint running shellcheck (shellcheck is written in haskell but we depend on go-shellcheck which is a packaged up version of it using wasm?). (#19958 (comment)) If I update it, I don't get bizarre wasm failures and it still doesn't complain about anything.
ilevkivskyi
approved these changes
Oct 8, 2025
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
Out of curiosity, were you consistently able to replicate the problem on 0.10.0, and consistently unable to replicate it on 0.11.0? It seemed like a sporadic problem to me, which only struck at random. Of course, no harm in bumping the version even if it is sporadic... |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting bizarre wasm failures from runtests running pre-commit
running actionlint running shellcheck (shellcheck is written in
haskell but we depend on go-shellcheck which is a packaged up version
of it using wasm?).
(#19958 (comment))
If I update it, I don't get bizarre wasm failures and it still doesn't
complain about anything.