-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Check class references to catch non-existant classes in match cases #20042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
This comment has been minimized.
This comment has been minimized.
|
For the primer, (since I was confused about this for test results) this happens because there's no type annotations in the function signature so everything becomes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe see if using type_info_from_type helps
|
The issue was moreso that we didn't get |
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: ibis (https://github.com/ibis-project/ibis)
- ibis/common/tests/test_grounds_py310.py:38: error: Too many positional patterns for class pattern [misc]
|
Fixes #20018.