-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[mypyc] Add minimal BytesWriter class librt #20297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help with random access and makes things a bit cleaner.
This comment has been minimized.
This comment has been minimized.
p-sawicki
approved these changes
Nov 25, 2025
We don't care about the semantic difference really, since we'll be dropping 3.9 support soon enough. Just make the test case pass.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
librt.strings.BytesWriterclass allow building abytesobject frombytesoru8components.Simple example use case:
It can be used at an alternative to
bytearrayorBytesIOin various use cases. The main benefit over stdlib classes is that we can provide (more) efficient mypyc primitives for various operations. The goal is to make it more efficient than eitherbytearrayorBytesIOin many use cases, eventually.The implementation is based on the implementation of
librt.internal.WriteBuffer, but it is somewhat different, since it will support also direct indexed item access (a bit likebytearray), so just appending to the end is not the only important use case. Direct item access is not implemented yet, but I'll add more features in follow-up PRs.This minimal implementation hasn't been optimized yet, and the API may not be final. It's experimental and only compiled if experimental features are explicitly enabled, so we can still make arbitrary API and ABI changes.