Address code duplication in mypyc/lib-rt #20368
Merged
+97
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bunch of code duplication in
mypyc/lib-rt, but it looks like there is no way to resolve this in a reasonable way. So instead I factor out duplicated code into a separate module, and add a test to verify files are synced.Note I type-check
lib-rtseparately now. Whatever I tried, I am getting weird error either likeor
etc. This is kind of a known problem, that we need to address long-term.
cc @JukkaL