Skip to content

Avoid treating pass and ... as no-op for reachability #20488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 2 commits into from
Jan 8, 2026
Merged

Avoid treating pass and ... as no-op for reachability #20488

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26814f2
Avoid treating pass/... as no-op for reachability
hauntsaninja Dec 30, 2025
773289b
test
hauntsaninja Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3181,12 +3181,10 @@ def is_noop_for_reachability(self, s: Statement) -> bool:
return True
elif isinstance(s, ReturnStmt) and is_literal_not_implemented(s.expr):
return True
elif isinstance(s, (RaiseStmt, PassStmt)):
elif isinstance(s, RaiseStmt):
return True
elif isinstance(s, ExpressionStmt):
if isinstance(s.expr, EllipsisExpr):
return True
elif isinstance(s.expr, CallExpr):
if isinstance(s.expr, CallExpr):
with self.expr_checker.msg.filter_errors(filter_revealed_type=True):
typ = get_proper_type(
self.expr_checker.accept(
Expand Down