gh-20495: Update checkpattern.py #20497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
A5rocks
suggested changes
Jan 1, 2026
Collaborator
A5rocks
left a comment
A5rocks
left a comment
There was a problem hiding this comment.
The current error message is more specific and IMO better. The other error in the issue isn't fixed by this, I think.
Collaborator
|
Yeah, agreed with A5rocks that we need the specific error message here + fixing why this doesn't have no_args set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-20495
CLASS_PATTERN_GENERIC_TYPE_ALIASinmypy/mypy/message_registry.pybelow is no longer used so you can decide to remove it or not: