Skip to content

Infra: Make PEP abstract extration more robust #4356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 3 commits into from
Apr 11, 2025
Merged

Infra: Make PEP abstract extration more robust #4356

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c7c23f
generate_rss: make pep_abstract more robust
woodruffw Apr 8, 2025
1def89a
Merge branch 'main' into ww/fix-pep-abstract
woodruffw Apr 8, 2025
5836a73
apply patch from @AA-Turner
woodruffw Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pep_sphinx_extensions/generate_rss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,14 @@
if title_node is None:
continue

para_node = None

Check warning on line 62 in pep_sphinx_extensions/generate_rss.py

View check run for this annotation

Codecov / codecov/patch

pep_sphinx_extensions/generate_rss.py#L62 

Added line #L62 was not covered by tests
if title_node.astext() == "Abstract":
return node.next_node(nodes.paragraph).astext().strip().replace("\n", " ")
para_node = node.next_node(nodes.paragraph)

Check warning on line 64 in pep_sphinx_extensions/generate_rss.py

View check run for this annotation

Codecov / codecov/patch

pep_sphinx_extensions/generate_rss.py#L64 

Added line #L64 was not covered by tests
elif title_node.astext() == "Introduction":
introduction = node.next_node(nodes.paragraph).astext().strip().replace("\n", " ")
para_node = node.next_node(nodes.paragraph)

Check warning on line 66 in pep_sphinx_extensions/generate_rss.py

View check run for this annotation

Codecov / codecov/patch

pep_sphinx_extensions/generate_rss.py#L66 

Added line #L66 was not covered by tests

if para_node:
introduction = para_node.astext().strip().replace("\n", " ")

Check warning on line 69 in pep_sphinx_extensions/generate_rss.py

View check run for this annotation

Codecov / codecov/patch

pep_sphinx_extensions/generate_rss.py#L68-L69 

Added lines #L68 - L69 were not covered by tests

return introduction

Expand Down