-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 780: Update to use sys.abi_info #4608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zklaus! On reflection, I think I like the name::value
syntax, it seems better than using things like sys_abi_info_free_threaded
as boolean markers.
Only two minor comments from me.
significant period of time, it looked likely that support would first be | ||
added in a fork. There are a lot of projects that depend on ``cffi``, which | ||
are likely fine to start depending on a fork for free-threading only, however | ||
depending on a fork for >=3.13 or for all Python versions seems like a much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending on a fork for >=3.13 or for all Python versions seems like a much | |
depending on a fork for >=3.13 or for all Python versions seemed like a much |
- ``{'free_threaded::True', 'pointer_bits::64'}``, | ||
``{'free_threaded::False', 'debug::True', 'pointer_bits::32'}`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be useful to add endianness to illustrate if string values are quoted or not under the new ::
scheme?
PEP 123: Summary of changes
)This PR updates PEP 780 to make use of the new
sys.abi_info
namespace that stems from the original PEP 780 discussion.Pinging @rgommers, @lysnikolaou.
📚 Documentation preview 📚: https://pep-previews--4608.org.readthedocs.build/