-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 817: Wheel Variants: Beyond Platform Tags #4740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DEKHTIARJonathan
wants to merge
63
commits into
python:main
Choose a base branch
from
wheelnext:pep-817-wheel-variants
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
f81a825
PEP 817: Wheel Variants: Beyond Platform Tags
DEKHTIARJonathan 5c3b867
Code-Owners editing
DEKHTIARJonathan 8e3d5ea
Apply suggestions from code review
mgorny f0d43f6
Switch to plain quotation marks
mgorny e16bf03
Move "definitions" to "specification" section
mgorny fede5ff
Reflow the cupy package list
mgorny c68242d
Update peps/pep-0817/appendix-variant-metadata-json-schema.rst
DEKHTIARJonathan 64f32ed
[PEP Review] JSON Schema Indent switched to 2
DEKHTIARJonathan 78ff40b
Replace the benchmark chart with SVG
mgorny a31b68b
Compact the SVG
mgorny 73753b9
Reflow text
mgorny 162ec7b
Replace typographic apostrophes
mgorny 0064073
Remove double spaces introduced while reflowing
mgorny 4b6f0f3
Apply suggestions from code review
mgorny 553f13e
Apply suggestions from code review
mgorny cd2ca30
Remove one more "induced"
mgorny 4222f09
Apply suggestions from code review
mgorny 3836f17
Apply suggestions from code review
mgorny 1e2d260
Fix list indent
mgorny 5cf8487
Uppercase RFC 2119 terms
mgorny 08e3778
Replace disjunction/conjunction with OR/AND
mgorny c40f3c9
Add "untrusted" to "security considerations"
mgorny 7e70c3d
Move "summary of changes" to the rationale
mgorny bada0ea
Shorten "Motivation" intro, move GROMACS example to "workarounds"
mgorny 6fecd44
Move reused links to "references" section
mgorny 972a0ab
Remove unnecessary project list from "limitations of ..."
mgorny 4596929
Shorten limitations of platform tags
mgorny 74a0811
Change "... limitations" to "... drawbacks" in section title
mgorny 32623c6
Remove solution bits from "motivation"
mgorny 3e4ae36
Simplify update problem explanation
mgorny 9702e03
Clarify CuPy
mgorny 63d824d
Combine paragraphs on extras
mgorny d27c571
Remove "motivation summary"
mgorny f48baa4
Add SLEAP quote
mgorny 1d44653
Move "out-of-scope features" to "rejected ideas"
mgorny 1062280
Update cupy package list, and clarify
mgorny 7332090
Revert "Move "out-of-scope features" to "rejected ideas""
mgorny fffefe0
Move glossary and overview into Rationale
mgorny a54fc2a
Remove speccy parts from "Overview" rationale
mgorny 5a512e5
Remove "summary of changes" for now
mgorny 7794674
Highlight the added filename part
mgorny 72d4f3f
Avoid forward-linking from rationale to spec
mgorny dc7b63b
Expand variant properties in rationale
mgorny 5748810
Better explain providers in "Rationale" section
mgorny 62be783
Readd info on using providers to the spec
mgorny 03a51cc
Explain metadata a bit in rationale
mgorny e5f0f9b
Clarify provider part of spec
mgorny e17f3f0
Explain ABI variant provider in the rationale
mgorny 2f80033
Rewording of confusing bits
mgorny 5d9c6db
Remove duplicate "publishes builds" verb
mgorny f6a132e
Apply suggestions from code review
mgorny 2f7b7da
project tree → source tree
mgorny 872213f
regular wheel → non-variant wheel
mgorny c66ecad
Loosen and clarify verification at install time
mgorny 80300c1
Make respecting enable-if mandatory
mgorny a60332b
Limit recommendations to install-time providers
mgorny 8bc3b51
Remove "after verifying their trustworthiness"
mgorny d590d04
Try to clarify build-time validation
mgorny c98613f
Update links to where security is covered now
mgorny 5257463
Remove duplicate/non-spec content in Providers spec
mgorny 5c43293
Move environment and pinning bits to rationale
mgorny a2d653d
Mention metadata bits in overview
mgorny 2ce4d07
Remove some duplication in "Provider information"
mgorny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.