Skip to content

Conversation

@JacobCoffee
Copy link
Member

Description

Closes

@JacobCoffee JacobCoffee requested a review from ewdurbin as a code owner October 3, 2024 18:48
@JacobCoffee JacobCoffee requested a review from ewdurbin October 23, 2024 19:27
Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this appears to work as expected, a couple notes on more thorough review.

@JacobCoffee JacobCoffee requested a review from ewdurbin November 6, 2024 19:34
@JacobCoffee
Copy link
Member Author

@ewdurbin any lingering thoughts here or is it ready you think?

@JacobCoffee
Copy link
Member Author

double checking again before merging against a dummy docs host with added in local rate limit and bugs host, seems like it will do the thing™

psf-salt on  rate [🤷✓] via  pyenv via ⍱ v2.4.1 on ☁️  (us-east-2) 
➜ curl -I -s -H "Host: bugs.python.org" --resolve "bugs.python.org:80:192.168.60.19" "http://bugs.python.org/_check"
HTTP/1.1 301 Moved Permanently
content-length: 0
location: https://bugs.python.org/_check


psf-salt on  rate [🤷✓] via  pyenv via ⍱ v2.4.1 on ☁️  (us-east-2) 
➜ curl -I -s -H "Host: bugs.python.org" --resolve "bugs.python.org:80:192.168.60.19" "http://bugs.python.org/_check"
HTTP/1.1 301 Moved Permanently
content-length: 0
location: https://bugs.python.org/_check


psf-salt on  rate [🤷✓] via  pyenv via ⍱ v2.4.1 on ☁️  (us-east-2) 
➜ curl -I -s -H "Host: bugs.python.org" --resolve "bugs.python.org:80:192.168.60.19" "http://bugs.python.org/_check"
HTTP/1.1 429 Too Many Requests
content-length: 117
cache-control: no-cache
content-type: text/html

@JacobCoffee JacobCoffee merged commit d8749ff into main Dec 18, 2024
2 checks passed
@JacobCoffee JacobCoffee deleted the rate-limit-at-lb branch December 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP rate limiting

3 participants