Skip to content

Conversation

@JacobCoffee
Copy link
Member

Description

  • Fixes issue where consul fails a salt state due to consul not being ready but we try to pull token

@JacobCoffee JacobCoffee requested a review from ewdurbin as a code owner August 5, 2025 17:07
@ewdurbin
Copy link
Member

ewdurbin commented Aug 5, 2025

This is excellent. Does that mean we can also remove this line?

while ! salt-call consul.cluster_ready | grep True; do echo 'waiting for consul'; sleep 1; done
or is it maybe just good insurance?

@JacobCoffee JacobCoffee changed the title fix: resolve race condition for consukl token fix: resolve race condition for consul token Aug 5, 2025
@JacobCoffee
Copy link
Member Author

@ewdurbin going to keep it for now as im hesitant to remove 😬

@JacobCoffee JacobCoffee merged commit 2deb99d into main Aug 7, 2025
2 checks passed
@JacobCoffee JacobCoffee deleted the fix-consul-race-condition branch August 7, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants