Skip to content

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Oct 9, 2024

This is follow-on work to supporting hooks in pyperf, and simply allows specifying hooks to run from pyperformance.

@mdboom mdboom requested a review from vstinner October 9, 2024 15:40
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(caveat: I don't know much about pyperf hooks)

Would it be worth adding a test?

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdboom mdboom merged commit eb539c6 into python:main Oct 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants