Skip to content

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Sep 16, 2025

@hugovk
Copy link
Member

hugovk commented Sep 16, 2025

What's unnecessary, what's incorrect, and why?

@AA-Turner
Copy link
Member

I agree with Hugo: when proposing a change, please provide appropriate context and rationale.

Here the git blame (at least via the UI) goes back to 788b53d ('Initial version of theme'; Jon Wayne Parrott). I'm on mobile and can't do significant research, but that does probably seem to be an error -- but instead of removing it, shall we change it to say 'python-docs-theme maintainers', or 'python core devs', or whatever?

I would prefer to split the Ruff lint rules to a different file (I'm not a fan of putting random config in pyproject.toml), but I know Hugo has differing opinions here.

A

@StanFromIreland
Copy link
Member Author

The lint rule exceptions are unnecessary since there are no infractions.

The distutils-sig being maintainers of this theme seems incorrect. I can change it to the "Python-docs-theme maintainers" Adam suggests.

@StanFromIreland StanFromIreland changed the title Remove unnecessary and incorrect sections from pyproject.toml Remove unnecessary lint rules and update authors in pyproject.toml Sep 17, 2025
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint rule exceptions are unnecessary since there are no infractions.

No infractions right now. If we remove the exceptions, a new PR can fail and the author will have to change their code to meet these rules. We don't want that.

@StanFromIreland StanFromIreland changed the title Remove unnecessary lint rules and update authors in pyproject.toml Update authors in pyproject.toml Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants