Skip to content

Conversation

code-review-doctor
Copy link
Contributor

Fixes #1986

Copy link

@rbanffy rbanffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@rbanffy rbanffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Not a full-time contributor. At least I had an approve button ;-)

@ambv ambv changed the title Some tests misusing assertTrue for comparisons fix Fix jobs/tests/test_models.py misusing assertTrue Mar 11, 2024
Copy link
Contributor

@ambv ambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid fix, and a straightforward change.

@hugovk
Copy link
Member

hugovk commented Mar 11, 2024

Here's some others, found using https://github.com/isidentical/teyit.

assert_ was removed in 3.12: https://docs.python.org/3/whatsnew/3.12.html#id3

diff --git a/downloads/tests/test_models.py b/downloads/tests/test_models.py
index f27e951..d31afae 100644
--- a/downloads/tests/test_models.py
+++ b/downloads/tests/test_models.py
@@ -82,8 +82,8 @@ class DownloadModelTests(BaseDownloadTests):
 
         release_38 = Release.objects.create(name='Python 3.8.0')
         self.assertFalse(release_38.is_version_at_least_3_9)
-        self.assert_(release_38.is_version_at_least_3_5)
+        self.assertTrue(release_38.is_version_at_least_3_5)
 
         release_310 = Release.objects.create(name='Python 3.10.0')
-        self.assert_(release_310.is_version_at_least_3_9)
-        self.assert_(release_310.is_version_at_least_3_5)
+        self.assertTrue(release_310.is_version_at_least_3_9)
+        self.assertTrue(release_310.is_version_at_least_3_5)

@JacobCoffee
Copy link
Member

@hugovk these assert_ bits i think will be cleaned up in #2535

@JacobCoffee
Copy link
Member

will merge after #2520 settles

@ewdurbin ewdurbin merged commit 81e2634 into python:main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some tests misusing assertTrue for comparisons
6 participants