Skip to content

fix: handle release objects with 'invalid' names #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2025
Merged

fix: handle release objects with 'invalid' names #2790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6374d2a
fix: handle release objects with 'invalid' names
JacobCoffee Oct 8, 2025
f809fd1
fix: handle release objects with 'invalid' names but on the method side
JacobCoffee Oct 8, 2025
fee61af
Merge branch 'main' into downloads-invalid-version-pslit-fix
JacobCoffee Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions downloads/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def get_version(self):
version = re.match(r'Python\s([\d.]+)', self.name)
if version is not None:
return version.group(1)
return None
return ""

def is_version_at_least(self, min_version_tuple):
v1 = []
Expand Down Expand Up @@ -291,7 +291,7 @@ def purge_fastly_download_pages(sender, instance, **kwargs):
purge_url('/downloads/source/')
purge_url('/downloads/windows/')
purge_url('/ftp/python/')
if instance.get_version() is not None:
if instance.get_version():
purge_url(f'/ftp/python/{instance.get_version()}/')
# See issue #584 for details
purge_url('/box/supernav-python-downloads/')
Expand Down
10 changes: 9 additions & 1 deletion downloads/tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def test_get_version_invalid(self):
with self.subTest(name=name):
release = Release.objects.create(name=name)
self.assertEqual(release.name, name)
self.assertIsNone(release.get_version())
self.assertEqual(release.get_version(), "")

def test_is_version_at_least(self):
self.assertFalse(self.release_275.is_version_at_least_3_5)
Expand All @@ -87,3 +87,11 @@ def test_is_version_at_least(self):
release_310 = Release.objects.create(name='Python 3.10.0')
self.assertTrue(release_310.is_version_at_least_3_9)
self.assertTrue(release_310.is_version_at_least_3_5)

def test_is_version_at_least_with_invalid_name(self):
"""Test that is_version_at_least returns False for releases with invalid names"""
invalid_release = Release.objects.create(name='Python install manager')
# Should return False instead of raising AttributeError
self.assertFalse(invalid_release.is_version_at_least_3_5)
self.assertFalse(invalid_release.is_version_at_least_3_9)
self.assertFalse(invalid_release.is_version_at_least_3_14)