Skip to content

Remove stubtest allowlists for paths in 3.13 #12730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove stubtest allowlists for paths in 3.13 #12730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ece24a
Remove stubtest allowlists for paths in 3.13
JelleZijlstra Oct 3, 2024
5d1573f
add back splitroot
JelleZijlstra Oct 3, 2024
13c1367
Restore exists
JelleZijlstra Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions stdlib/@tests/stubtest_allowlists/darwin-py313.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# new in py313
posixpath.splitroot

# Depends on HAVE_NCURSESW and how we install CPython,
# should be removed when 3.13 will be officially released:
_?curses.unget_wch
Expand Down
2 changes: 0 additions & 2 deletions stdlib/@tests/stubtest_allowlists/linux-py313.txt
View file
Open in desktop

This file was deleted.

6 changes: 5 additions & 1 deletion stdlib/@tests/stubtest_allowlists/py313.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

# TODO: triage these new errors
_tkinter.create
os.path.splitroot
tkinter.Misc.after_info
tkinter.Misc.busy
tkinter.Misc.busy_cget
Expand All @@ -25,6 +24,11 @@ tkinter.Misc.tk_busy_status
tkinter.Text.count
tkinter.Wm.wm_attributes

# Name of the "p" parameter changed to "path", but is
# expected to get changed back in 3.13.1:
# https://github.com/python/cpython/pull/124097
(os\.path|ntpath|posixpath)\.splitroot

# ======================================
# Pre-existing errors from Python <=3.12
# ======================================
Expand Down
11 changes: 4 additions & 7 deletions stdlib/@tests/stubtest_allowlists/win32-py313.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
# New in py313 (triage these!)
ntpath.exists
ntpath.lexists
ntpath.splitroot
os.path.exists
os.path.lexists

# Undocumented internal method, not really for public consumption.
# (Hard to add types for unless we add stubs for the undocumented _overlapped module...)
asyncio.IocpProactor.finish_socket_func
asyncio.windows_events.IocpProactor.finish_socket_func

# Argument was made keyword-only, may be fixed in 3.13.1
# https://github.com/python/cpython/issues/124917
(os\.path|ntpath)\.l?exists