[openpyxl] Reorder overloads #14201
Merged
[openpyxl] Reorder overloads #14201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help with python#14194
Collaborator
Author
|
I'm not sure this really helps with #14194, but the new order seems more logical to me in any case. We can always add a |
This comment has been minimized.
This comment has been minimized.
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
I'm not sure I understand why this class is generic, from the runtime definition it appears it accepts both strings and Color objects no matter what.
But at least this change seems harmless and I agree the new order makes a bit more sense.
JelleZijlstra
approved these changes
May 31, 2025
Avasam
requested changes
Jun 1, 2025
Member
|
Looks like this is the only one left for #14194 |
Co-authored-by: Avasam <[email protected]>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Avasam
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with #14194