Mark stub-only types with runtime aliases as @type_check_only in stdlib
#14717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
approved these changes
Sep 14, 2025
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Contributor
|
This PR causes downstream errors in from types import NoneType, EllipsisType, NotImplementedType
extra_types: list[type] = [
NoneType, # OK
EllipsisType, # OK
NotImplementedType # E: "_NotImplementedType" is marked as @type_check_only
]This type checked without errors in version 1.1.405, but since 1.1.406 is issues the error due to the updated stubs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtest no longer complains when these types are marked
@type_check_onlysince python/mypy#19568