Added annotation for five functions in Authlib #14800
+14
−8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,20 @@ | ||
| from logging import Logger | ||
| from typing import Any | ||
|
|
||
| import requests # type: ignore[import-untyped] | ||
| from authlib.integrations.base_client.sync_app import OAuth1Base, OAuth2Base | ||
|
|
||
| log: Logger | ||
|
|
||
| __all__ = ["AsyncOAuth1Mixin", "AsyncOAuth2Mixin"] | ||
|
|
||
| class AsyncOAuth1Mixin(OAuth1Base): | ||
| async def request(self, method: str, url: str, token: dict[str, Any] | None = None, **kwargs) -> requests.Response: ... | ||
|
||
| async def create_authorization_url(self, redirect_uri: str | None = None, **kwargs) -> dict[str, Any]: ... | ||
| async def fetch_access_token(self, request_token: dict[str, Any] | None = None, **kwargs) -> dict[str, Any]: ... | ||
|
|
||
| class AsyncOAuth2Mixin(OAuth2Base): | ||
| async def load_server_metadata(self) -> dict[str, Any]: ... | ||
| async def request(self, method: str, url: str, token: dict[str, Any] | None = None, **kwargs) -> requests.Response: ... | ||
| async def create_authorization_url(self, redirect_uri: str | None = None, **kwargs) -> dict[str, Any]: ... | ||
| async def fetch_access_token(self, redirect_uri: str | None = None, **kwargs) -> dict[str, Any]: ... | ||
Spider84pr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you are importing a 3rd-party lib, you need to add
types-requestsas a dependency: https://github.com/python/typeshed/blob/main/stubs/Authlib/METADATA.tomlUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sobolevn I must do it like so?
Metadata. toml
dependencies = [
"types-httpx",
]
Sorry, I've faced it first time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Spider84pr
requires = ["types-requests"]should be correct. See for examplestubs/pysftp/METADATA.toml.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srittau I have added required section and changed the library as we discussed with @sobolevn in the below, but the most test failed
I don't know what to do