Skip to content

Fix wrong types for xlrd.(Cell.value|Sheet.get_rows) #14894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2025
Merged

Fix wrong types for xlrd.(Cell.value|Sheet.get_rows) #14894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bc2f50
Fix wrong types for xlrd.(Cell.value|Sheet.get_rows)
Jackenmen Oct 18, 2025
a82948b
Update stubs/xlrd/xlrd/sheet.pyi
Jackenmen Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions stubs/xlrd/xlrd/sheet.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from _typeshed import SupportsWrite
from array import array
from collections.abc import Callable, Sequence
from collections.abc import Callable, Generator, Sequence
from typing import Any, Final, Literal, overload

from .biffh import *
Expand Down Expand Up @@ -43,10 +43,10 @@ ctype_text: Final[dict[int, str]]

class Cell(BaseObject):
__slots__ = ["ctype", "value", "xf_index"]
ctype: int
value: str
ctype: Literal[0, 1, 2, 3, 4, 5, 6]
value: str | float
xf_index: int | None
def __init__(self, ctype: int, value: str, xf_index: int | None = None) -> None: ...
def __init__(self, ctype: Literal[0, 1, 2, 3, 4, 5, 6], value: str, xf_index: int | None = None) -> None: ...

empty_cell: Final[Cell]

Expand Down Expand Up @@ -147,7 +147,7 @@ class Sheet(BaseObject):
def __getitem__(self, item: int) -> list[Cell]: ...
@overload
def __getitem__(self, item: tuple[int, int]) -> Cell: ...
def get_rows(self) -> tuple[list[Cell], ...]: ...
def get_rows(self) -> Generator[list[Cell]]: ...
__iter__ = get_rows
def row_types(self, rowx: int, start_colx: int = 0, end_colx: int | None = None) -> Sequence[int]: ...
def row_values(self, rowx: int, start_colx: int = 0, end_colx: int | None = None) -> Sequence[str]: ...
Expand Down