Skip to content

Remove zlib.ZLIBNG_VERSION Windows requirement #14947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 30, 2025
Merged

Remove zlib.ZLIBNG_VERSION Windows requirement #14947

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6b9d64
Modify ZLIBNG_VERSION condition for Windows
StanFromIreland Oct 30, 2025
e1ebbd2
Commit
StanFromIreland Oct 30, 2025
8dd58d3
Commit
StanFromIreland Oct 30, 2025
f47933c
Fix allowlist
StanFromIreland Oct 30, 2025
f77f93b
Review
StanFromIreland Oct 30, 2025
72b39c3
compression too
StanFromIreland Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions stdlib/@tests/stubtest_allowlists/common.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ sys.ps1 # Available in interactive mode
sys.ps2 # Available in interactive mode
sys.tracebacklimit # Must be set first

# This depends on how Python was built
zlib.ZLIBNG_VERSION


# ==========================================================
# Other allowlist entries that cannot or should not be fixed
Expand Down
6 changes: 3 additions & 3 deletions stdlib/zlib.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ Z_RLE: Final = 3
Z_SYNC_FLUSH: Final = 2
Z_TREES: Final = 6

if sys.version_info >= (3, 14) and sys.platform == "win32":
# Available when zlib was built with zlib-ng, usually only on Windows
ZLIBNG_VERSION: Final[str]
if sys.version_info >= (3, 14):
# Available when zlib was built with zlib-ng
ZLIBNG_VERSION: Final[str] # type: ignore[attr-defined]

class error(Exception): ...

Expand Down
Loading