Skip to content

[docker-py] Fix the type of Model and Collection client attribute #15083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
Merged

[docker-py] Fix the type of Model and Collection client attribute #15083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions stubs/docker/docker/models/resource.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
from typing import Any, Generic, NoReturn, TypeVar
from typing_extensions import Self

from docker import APIClient
from docker import DockerClient

_T = TypeVar("_T", bound=Model)

class Model:
id_attribute: str
client: APIClient | None
client: DockerClient | None
collection: Collection[Self] | None
attrs: dict[str, Any]
def __init__(
self, attrs: dict[str, Any] | None = None, client: APIClient | None = None, collection: Collection[Self] | None = None
self, attrs: dict[str, Any] | None = None, client: DockerClient | None = None, collection: Collection[Self] | None = None
) -> None: ...
def __eq__(self, other) -> bool: ...
def __hash__(self) -> int: ...
Expand All @@ -23,8 +23,8 @@ class Model:

class Collection(Generic[_T]):
model: type[_T]
client: APIClient
def __init__(self, client: APIClient | None = None) -> None: ...
client: DockerClient
def __init__(self, client: DockerClient | None = None) -> None: ...
def __call__(self, *args, **kwargs) -> NoReturn: ...
def list(self) -> list[_T]: ...
def get(self, key: str) -> _T: ...
Expand Down