add support for stub test files, add overloads_definitions_stub.pyi

Author: carljm

conformance/results/mypy/overloads_definitions.toml

@@ -2,10 +2,11 @@ conformant = "Partial"
 conformance_automated = "Fail"
 notes = """
 Does not allow an overload with no implementation in an abstract base class.
+Allows @override to be on all overloads and implementation, instead of just implementation.
 """
 errors_diff = """
+Line 245: Expected 1 errors
 Line 49: Unexpected errors ['overloads_definitions.py:49: error: An overloaded function outside a stub file must have an implementation  [no-overload-impl]']
-Line 202: Unexpected errors ['overloads_definitions.py:202: error: Signature of "good_override" incompatible with supertype "Base"  [override]']
 """
 output = """
 overloads_definitions.py:14: error: Single overload definition, multiple required  [misc]
@@ -18,30 +19,6 @@ overloads_definitions.py:88: error: Overloaded function implementation does not
 overloads_definitions.py:91: error: Overload does not consistently use the "@classmethod" decorator on all function signatures.  [misc]
 overloads_definitions.py:133: error: @final should be applied only to overload implementation  [misc]
 overloads_definitions.py:148: error: @final should be applied only to overload implementation  [misc]
-overloads_definitions.py:176: error: Cannot override final attribute "final_method" (previously declared in base class "Base")  [misc]
-overloads_definitions.py:176: error: Signature of "final_method" incompatible with supertype "Base"  [override]
-overloads_definitions.py:176: note:      Superclass:
-overloads_definitions.py:176: note:          @overload
-overloads_definitions.py:176: note:          def final_method(self, x: int) -> int
-overloads_definitions.py:176: note:          @overload
-overloads_definitions.py:176: note:          def final_method(self, x: str) -> str
-overloads_definitions.py:176: note:      Subclass:
-overloads_definitions.py:176: note:          def final_method(self, x: int | str) -> int | str
-overloads_definitions.py:183: error: Method "bad_override" is marked as an override, but no base method was found with this name  [misc]
-overloads_definitions.py:202: error: Signature of "good_override" incompatible with supertype "Base"  [override]
-overloads_definitions.py:202: note:      Superclass:
-overloads_definitions.py:202: note:          def good_override(self, x: int | str) -> int | str
-overloads_definitions.py:202: note:      Subclass:
-overloads_definitions.py:202: note:          @overload
-overloads_definitions.py:202: note:          def good_override(self, x: int) -> int
-overloads_definitions.py:202: note:          @overload
-overloads_definitions.py:202: note:          def good_override(self, x: str) -> str
-overloads_definitions.py:217: error: Signature of "to_override" incompatible with supertype "Base"  [override]
-overloads_definitions.py:217: note:      Superclass:
-overloads_definitions.py:217: note:          def to_override(self, x: int | str) -> int | str
-overloads_definitions.py:217: note:      Subclass:
-overloads_definitions.py:217: note:          @overload
-overloads_definitions.py:217: note:          def to_override(self, x: int) -> int
-overloads_definitions.py:217: note:          @overload
-overloads_definitions.py:217: note:          def to_override(self, x: str) -> str
+overloads_definitions.py:196: error: Cannot override final attribute "final_method" (previously declared in base class "Base")  [misc]
+overloads_definitions.py:211: error: Method "bad_override" is marked as an override, but no base method was found with this name  [misc]
 """

conformance/results/mypy/overloads_definitions_stub.toml

@@ -0,0 +1,18 @@
+conformant = "Partial"
+notes = """
+Allows @override to appear in a stub file not on the first overload.
+"""
+conformance_automated = "Fail"
+errors_diff = """
+Line 168: Expected 1 errors
+"""
+output = """
+overloads_definitions_stub.pyi:13: error: Single overload definition, multiple required  [misc]
+overloads_definitions_stub.pyi:37: error: Overload does not consistently use the "@staticmethod" decorator on all function signatures.  [misc]
+overloads_definitions_stub.pyi:38: error: Self argument missing for a non-static method (or an invalid type for self)  [misc]
+overloads_definitions_stub.pyi:46: error: Overload does not consistently use the "@classmethod" decorator on all function signatures.  [misc]
+overloads_definitions_stub.pyi:85: error: In a stub file @final must be applied only to the first overload  [misc]
+overloads_definitions_stub.pyi:101: error: In a stub file @final must be applied only to the first overload  [misc]
+overloads_definitions_stub.pyi:128: error: Cannot override final attribute "final_method" (previously declared in base class "Base")  [misc]
+overloads_definitions_stub.pyi:140: error: Method "bad_override" is marked as an override, but no base method was found with this name  [misc]
+"""

conformance/results/pyre/overloads_definitions.toml

@@ -5,12 +5,12 @@ Does not allow an overload with no implementation in a Protocol or an abstract b
 Expects @final/@override on all overloads and implementation, instead of implementation only.
 """
 errors_diff = """
-Line 217: Expected 1 errors
+Line 245: Expected 1 errors
 Lines 148, 150: Expected error (tag 'invalid_final_2')
 Line 40: Unexpected errors ['overloads_definitions.py:40:4 Missing overload implementation [42]: Overloaded function `MyProto.func3` must have an implementation.']
 Line 51: Unexpected errors ['overloads_definitions.py:51:4 Missing overload implementation [42]: Overloaded function `MyAbstractBase.func4` must have an implementation.']
 Line 128: Unexpected errors ['overloads_definitions.py:128:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
-Line 211: Unexpected errors ['overloads_definitions.py:211:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
+Line 239: Unexpected errors ['overloads_definitions.py:239:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
 """
 output = """
 overloads_definitions.py:15:0 Incompatible overload [43]: At least two overload signatures must be present.
@@ -25,8 +25,8 @@ overloads_definitions.py:97:4 Incompatible overload [43]: The implementation of
 overloads_definitions.py:97:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
 overloads_definitions.py:128:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
 overloads_definitions.py:139:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
-overloads_definitions.py:176:4 Invalid override [40]: `overloads_definitions.Child.final_method` cannot override final method defined in `Base`.
-overloads_definitions.py:192:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
-overloads_definitions.py:192:4 Invalid override [40]: `overloads_definitions.Child.bad_override` is decorated with @override, but no method of the same name exists in superclasses of `Child`.
-overloads_definitions.py:211:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions.py:204:4 Invalid override [40]: `overloads_definitions.Child.final_method` cannot override final method defined in `Base`.
+overloads_definitions.py:220:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions.py:220:4 Invalid override [40]: `overloads_definitions.Child.bad_override` is decorated with @override, but no method of the same name exists in superclasses of `Child`.
+overloads_definitions.py:239:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
 """

conformance/results/pyre/overloads_definitions_stub.toml

@@ -0,0 +1,27 @@
+conformant = "Partial"
+notes = """
+Expects @final and @override to be present on all overloads, not just first.
+"""
+conformance_automated = "Fail"
+errors_diff = """
+Line 168: Expected 1 errors
+Lines 80, 82, 85, 87: Expected error (tag 'invalid_final')
+Lines 96, 98, 101: Expected error (tag 'invalid_final_2')
+Lines 122, 128, 129, 133: Expected error (tag 'override-final')
+Line 75: Unexpected errors ['overloads_definitions_stub.pyi:75:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
+Line 91: Unexpected errors ['overloads_definitions_stub.pyi:91:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
+Line 146: Unexpected errors ['overloads_definitions_stub.pyi:146:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
+Line 162: Unexpected errors ['overloads_definitions_stub.pyi:162:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
+Line 174: Unexpected errors ['overloads_definitions_stub.pyi:174:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).']
+"""
+output = """
+overloads_definitions_stub.pyi:14:0 Incompatible overload [43]: At least two overload signatures must be present.
+overloads_definitions_stub.pyi:43:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions_stub.pyi:52:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions_stub.pyi:75:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions_stub.pyi:91:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions_stub.pyi:142:4 Invalid override [40]: `overloads_definitions_stub.Child.bad_override` is decorated with @override, but no method of the same name exists in superclasses of `Child`.
+overloads_definitions_stub.pyi:146:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions_stub.pyi:162:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+overloads_definitions_stub.pyi:174:4 Incompatible overload [43]: This definition does not have the same decorators as the preceding overload(s).
+"""

conformance/results/pyre/version.toml

@@ -1,2 +1,2 @@
 version = "pyre 0.9.23"
-test_duration = 5.9
+test_duration = 6.7

conformance/results/pyright/overloads_definitions.toml

@@ -4,7 +4,7 @@ Allows @final/@override on all overloads and implementation; should be implement
 """
 conformance_automated = "Fail"
 errors_diff = """
-Line 217: Expected 1 errors
+Line 245: Expected 1 errors
 Lines 148, 150: Expected error (tag 'invalid_final_2')
 """
 output = """
@@ -27,10 +27,6 @@ overloads_definitions.py:88:9 - error: Overloaded implementation is not consiste
 overloads_definitions.py:93:9 - error: Overloads for "func6" use @classmethod inconsistently (reportInconsistentOverload)
 overloads_definitions.py:97:15 - warning: Instance methods should take a "self" parameter (reportSelfClsParameterName)
 overloads_definitions.py:135:9 - error: Overload for "invalid_final" is marked @final but implementation is not (reportInconsistentOverload)
-overloads_definitions.py:176:9 - error: Method "final_method" cannot override final method defined in class "Base" (reportIncompatibleMethodOverride)
-overloads_definitions.py:176:9 - error: Method "final_method" overrides class "Base" in an incompatible manner
-  Return type mismatch: base method returns type "int", override returns type "int | str"
-    Type "int | str" is not assignable to type "int"
-      "str" is not assignable to "int" (reportIncompatibleMethodOverride)
-overloads_definitions.py:192:9 - error: Method "bad_override" is marked as override, but no base method of same name is present (reportGeneralTypeIssues)
+overloads_definitions.py:204:9 - error: Method "final_method" cannot override final method defined in class "Base" (reportIncompatibleMethodOverride)
+overloads_definitions.py:220:9 - error: Method "bad_override" is marked as override, but no base method of same name is present (reportGeneralTypeIssues)
 """

conformance/results/pyright/overloads_definitions_stub.toml

@@ -0,0 +1,20 @@
+conformant = "Partial"
+notes = """
+Does not enforce that @final/@override in a stub should be only on first overload.
+Does not enforce @override when correctly used with an overloaded method in a stub file.
+"""
+conformance_automated = "Fail"
+errors_diff = """
+Line 168: Expected 1 errors
+Lines 80, 82, 85, 87: Expected error (tag 'invalid_final')
+Lines 96, 98, 101: Expected error (tag 'invalid_final_2')
+Lines 140, 142: Expected error (tag 'bad_override')
+"""
+output = """
+overloads_definitions_stub.pyi:14:5 - error: "func1" is marked as overload, but additional overloads are missing (reportInconsistentOverload)
+overloads_definitions_stub.pyi:38:9 - error: Overloads for "func5" use @staticmethod inconsistently (reportInconsistentOverload)
+overloads_definitions_stub.pyi:38:15 - warning: Instance methods should take a "self" parameter (reportSelfClsParameterName)
+overloads_definitions_stub.pyi:48:9 - error: Overloads for "func6" use @classmethod inconsistently (reportInconsistentOverload)
+overloads_definitions_stub.pyi:52:15 - warning: Instance methods should take a "self" parameter (reportSelfClsParameterName)
+overloads_definitions_stub.pyi:133:9 - error: Method "final_method" cannot override final method defined in class "Base" (reportIncompatibleMethodOverride)
+"""