Skip to content

Commit dfad1b7

Browse files
committed
Conformance - skip Pyre on Windows as it's not supported
1 parent 85ca00b commit dfad1b7

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

conformance/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ To run the conformance test suite:
6060
* Switch to the `conformance` subdirectory and install all dependencies (`pip install -r requirements.txt`).
6161
* Switch to the `src` subdirectory and run `python main.py`.
6262

63-
Note that some type checkers may not run on some platforms. If a type checker fails to install, tests will be skipped for that type checker.
63+
Note that some type checkers may not run on some platforms. If a type checker fails to install, tests will be skipped for that type checker.
64+
Currently, the only unsupported type checker is Pyre on Windows.
6465

6566
## Reporting Conformance Results
6667

conformance/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ tqdm
44
pyright
55
mypy
66
pip
7-
pyre-check
7+
pyre-check; platform_system != "Windows"
88
pytype

conformance/src/type_checker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,6 +387,6 @@ def parse_errors(self, output: Sequence[str]) -> dict[int, list[str]]:
387387
TYPE_CHECKERS: Sequence[TypeChecker] = (
388388
MypyTypeChecker(),
389389
PyrightTypeChecker(),
390-
PyreTypeChecker(),
390+
*([] if os.name == "nt" else [PyreTypeChecker()]),
391391
PytypeTypeChecker(),
392392
)

0 commit comments

Comments
 (0)