Fix subscription of Unpack causing nested Unpacks to not be resolved correctly #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks, this looks close to ready.
CHANGELOG.md
Outdated
| subscripted objects) had wrong parameters if they were directly | ||
| subscripted with an `Unpack` object. | ||
| Patch by [Daraan](https://github.com/Daraan). | ||
| - Fix error in subscription of Unpack aliases causing nested Unpacks |
Member
There was a problem hiding this comment.
Suggested change
| - Fix error in subscription of Unpack aliases causing nested Unpacks | |
| - Fix error in subscription of `Unpack` aliases causing nested Unpacks |
src/test_typing_extensions.py
Outdated
| def test_substitution(self): | ||
| Ts = TypeVarTuple("Ts") | ||
| unpacked_str = Unpack[Ts][str] | ||
| with self.subTest("Check substitution result"): |
Member
There was a problem hiding this comment.
No need for subTest for a single test
src/test_typing_extensions.py
Outdated
|
|
||
| TupleAliasTsT = Variadic[Tuple[Unpack[Ts], T]] | ||
| # Equivalent Forms | ||
| with self.subTest("Equivalence of variadic arguments"): |
Member
There was a problem hiding this comment.
Only use subTest in a loop. This one should probably just be a separate test method.
formatting to changelog Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Daraan <[email protected]>
JelleZijlstra
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Unpack alias backport had an issue that it did not resolve correctly during substition.
This PR fixes that the following should hold, or rather that the subscription does not raise a
TypeError.This fixes #474 and was solved by simply adding the Python 3.12+ code to the alias classes.
Sitenote: This is only slightly related to #103, the code sample there also did not work in 3.11 after the backport was used. However, the error is not related and still persists for <=3.10.