Change issue text on third_party failure to include exact run URL #516
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianschubert
changed the title
JelleZijlstra
approved these changes
Dec 6, 2024
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Cool! This would be nice for the typeshed daily test too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this SO answer, it's possible generate a URL for the current workflow run. We can use this in the issue body to save a few clicks and make it easier to find the right run when looking at old issues.
I tried this on my fork and it seems to be working great. Here's an example of a workflow run that prints its own URL using this setup (see the error in the dummy-print-url job): https://github.com/brianschubert/typing_extensions/actions/runs/12205086165