Skip to content

Copy-edit and add test #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Copy-edit and add test #541

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3386627
Copy-edit and add test
JelleZijlstra Mar 18, 2025
e9d9de9
Update CHANGELOG.md
JelleZijlstra Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Bugfixes and changed features:
- Backport CPython PR [#124795](https://github.com/python/cpython/pull/124795):
fix `TypeAliasType` not raising an error on non-tuple inputs for `type_params`.
Patch by [Daraan](https://github.com/Daraan).
- Fix that lists and ... could not be used for parameter expressions for `TypeAliasType`
- Fix that lists and `...` could not be used for parameter expressions for `TypeAliasType`
instances before Python 3.11.
Patch by [Daraan](https://github.com/Daraan).
- Fix error on Python 3.10 when using `typing.Concatenate` and
Expand All @@ -48,9 +48,9 @@ Bugfixes and changed features:
to reflect Python 3.13+ behavior: A value assigned to `__total__` in the class body of a
`TypedDict` will be overwritten by the `total` argument of the `TypedDict` constructor.
Patch by [Daraan](https://github.com/Daraan), backporting a CPython PR by Jelle Zijlstra.
- Fix for Python 3.11 that now `isinstance(typing_extensions.Unpack[...], TypeVar)`
evaluates to `False`, however still `True` for <3.11.
Patch by [Daraan](https://github.com/Daraan)
- `isinstance(typing_extensions.Unpack[...], TypeVar)` now evaluated to `False` on Python 3.11
and newer, but remains `True` on versions before 3.11.
Patch by [Daraan](https://github.com/Daraan).

# Release 4.12.2 (June 7, 2024)

Expand Down
8 changes: 8 additions & 0 deletions src/test_typing_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5045,6 +5045,14 @@ def test_backwards_compatibility(self):
self.assertIs(TD.__extra_items__, NoExtraItems)
self.assertEqual(TD.__annotations__, {"extra_items": int})

def test_cannot_combine_closed_and_extra_items(self):
with self.assertRaisesRegex(
TypeError,
"Cannot combine closed=True and extra_items"
):
class TD(TypedDict, closed=True, extra_items=range):
x: str


class AnnotatedTests(BaseTestCase):

Expand Down
Loading