-
-
Notifications
You must be signed in to change notification settings - Fork 128
Add SQLAlchemy to third-party daily tests #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
f3095cc
4f01c01
e131290
b7c1442
d285526
c7e8291
f2e9f18
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -300,6 +300,51 @@ jobs: | |
| - name: Run cattrs tests | ||
| run: cd cattrs; pdm run pytest tests | ||
|
|
||
| sqlalchemy: | ||
| name: sqlalchemy tests | ||
| needs: skip-schedule-on-fork | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| # PyPy is deliberately omitted here, since SQLAlchemy's tests | ||
| # fail on PyPy for reasons unrelated to typing_extensions. | ||
| python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13" ] | ||
| checkout-ref: [ "main", "rel_2_0" ] | ||
| # sqlalchemy tests fail when using the Ubuntu 24.04 runner | ||
| # https://github.com/sqlalchemy/sqlalchemy/commit/8d73205f352e68c6603e90494494ef21027ec68f | ||
| runs-on: ubuntu-22.04 | ||
| timeout-minutes: 60 | ||
| steps: | ||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| allow-prereleases: true | ||
| - name: Install uv | ||
| run: curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| - name: Checkout sqlalchemy | ||
| run: for i in {1..2}; do git clone -b ${{ matrix.checkout-ref }} --depth=1 https://github.com/sqlalchemy/sqlalchemy.git && break; done | ||
| - name: Checkout typing_extensions | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| path: typing-extensions-latest | ||
| - name: Install sqlalchemy test dependencies | ||
| run: uv pip install --system tox setuptools | ||
| - name: List installed dependencies | ||
| # Note: tox installs SQLAlchemy and its dependencies in a different isolated | ||
| # environment before running the tests. To see the dependencies installed | ||
| # in the test environment, look for the line 'freeze> python -m pip freeze --all' | ||
| # in the output of the test step below. | ||
| run: uv pip list | ||
| - name: Run sqlalchemy tests | ||
| run: | | ||
| cd sqlalchemy | ||
| tox -e github-nocext \ | ||
| --force-dep "typing-extensions @ file://$(pwd)/../typing-extensions-latest" \ | ||
| -- -q --nomemory --notimingintensive | ||
| env: | ||
| TOX_WORKERS: -n4 | ||
|
||
|
|
||
| create-issue-on-failure: | ||
| name: Create an issue if daily tests failed | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -312,6 +357,7 @@ jobs: | |
| - typed-argument-parser | ||
| - mypy | ||
| - cattrs | ||
| - sqlalchemy | ||
|
|
||
| if: >- | ||
| ${{ | ||
|
|
@@ -326,6 +372,7 @@ jobs: | |
| || needs.typed-argument-parser.result == 'failure' | ||
| || needs.mypy.result == 'failure' | ||
| || needs.cattrs.result == 'failure' | ||
| || needs.sqlalchemy.result == 'failure' | ||
| ) | ||
| }} | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency's sake, I'd like to keep this command similar to the command in the other tests, i.e. using
&&.