Skip to content

Conversation

@srittau
Copy link
Collaborator

@srittau srittau commented Apr 1, 2025

No description provided.

@srittau
Copy link
Collaborator Author

srittau commented Apr 1, 2025

Ideally I'd want to use something like continue-on-error: ${{ matrix.python-version == '3.14-dev' }}, but I don't think it's possible. (We could of course emulate this by changing the shell command, but I don't like that.)

@brianschubert
Copy link
Member

but I don't think it's possible.

I think it might be? I saw something similar in the SQLAlchemy tests: https://github.com/sqlalchemy/sqlalchemy/blob/main/.github/workflows/run-test.yaml#L121

@srittau
Copy link
Collaborator Author

srittau commented Apr 1, 2025

Huh, I tried that but VSCode flagged that as invalid and the GitHub docs didn't mention it. I'll change it.

@srittau srittau marked this pull request as ready for review April 1, 2025 13:13
@Daraan
Copy link
Contributor

Daraan commented Apr 2, 2025

@srittau
Copy link
Collaborator Author

srittau commented Apr 2, 2025

In principle I like the idea of a warning message, but I didn't want to complicate the CI scripts for now.

@brianschubert
Copy link
Member

Can/should we add a warning in a failing case?

I think we get this for free - it seems an error annotation still gets emitted for the failing step even when the job doesn't fail: https://github.com/python/typing_extensions/actions/runs/14196009731

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@JelleZijlstra JelleZijlstra merged commit d44e9cf into python:main May 5, 2025
21 checks passed
@JelleZijlstra
Copy link
Member

Working on a PR to make the 3.14 tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants