-
-
Notifications
You must be signed in to change notification settings - Fork 123
Add Coverage workflow #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Daraan
wants to merge
37
commits into
python:main
Choose a base branch
from
Daraan:add-coverage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+148
−1
Open
Changes from 14 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
7078342
Add coverage workflow
Daraan 56faf0f
Add coverage summary
Daraan 045b6f7
add PR write permission
Daraan 21b240c
report line misses in logs
Daraan 71daf3d
Merge branch 'main' into add-coverage
Daraan 3b6319d
Remove install check again
Daraan e69ace4
Merge remote-tracking branch 'refs/remotes/origin/add-coverage' into …
Daraan 4384206
coverage not on mypy
Daraan b852953
Feedback; include temp files in .coverage
Daraan 022d37b
Merge remote-tracking branch 'upstream' into add-coverage
Daraan 9f1b3e1
check files present
Daraan 4bd0aa1
Add omit to final output
Daraan 7a7d6b3
Read env
Daraan ba46124
Use pyproject.toml for coverage
Daraan b9613f7
clean comment
Daraan 525e198
Merge branch 'main' into add-coverage
Daraan 034ec43
Zizmor feedback: Pin actions
Daraan 88ba8f6
Merge branch 'main' into add-coverage
Daraan 6c43f31
Test without permissions override
Daraan 943aba7
Merge branch 'main' into add-coverage
Daraan 5bbafa0
Revert "Test without permissions override"
Daraan ee8f319
rework pr comment with workflow_run
Daraan 2757de5
overwrite pr number
Daraan 084e39d
na
Daraan 6ed9889
continue on error as v4 has a bug
Daraan f48d961
slim workflow_run
Daraan 8d7600b
WIP: checkout files
Daraan 8677db5
adjust filename
Daraan f77717e
fix dir
Daraan 4cc732b
recheck
Daraan 30a30d1
recheck
Daraan b03f51f
recheck
Daraan 1a7c6e5
Fix file/path
Daraan 355ccd7
cleanup
Daraan 90c0e0c
wrong event name
Daraan b16e770
add pr write
Daraan 26ace2b
Merge branch 'main' into add-coverage
Daraan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,14 +64,40 @@ jobs: | |
python-version: ${{ matrix.python-version }} | ||
allow-prereleases: true | ||
|
||
- name: Test typing_extensions | ||
- name: Install coverage | ||
if: ${{ !startsWith(matrix.python-version, 'pypy') }} | ||
run: | | ||
# Be wary that this does not install typing_extensions in the future | ||
pip install coverage | ||
|
||
- name: Test typing_extensions with coverage | ||
if: ${{ !startsWith(matrix.python-version, 'pypy') }} | ||
run: | | ||
# Be wary of running `pip install` here, since it becomes easy for us to | ||
# accidentally pick up typing_extensions as installed by a dependency | ||
cd src | ||
python --version # just to make sure we're running the right one | ||
# Run tests under coverage | ||
export COVERAGE_FILE=.coverage_${{ matrix.python-version }} | ||
python -m coverage run -m unittest test_typing_extensions.py | ||
- name: Test typing_extensions no coverage on pypy | ||
if: ${{ startsWith(matrix.python-version, 'pypy') }} | ||
run: | | ||
# Be wary of running `pip install` here, since it becomes easy for us to | ||
# accidentally pick up typing_extensions as installed by a dependency | ||
cd src | ||
python --version # just to make sure we're running the right one | ||
python -m unittest test_typing_extensions.py | ||
|
||
- name: Archive code coverage results | ||
if: ${{ !startsWith(matrix.python-version, 'pypy') }} | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: .coverage_${{ matrix.python-version }} | ||
path: ./src/.coverage* | ||
include-hidden-files: true | ||
compression-level: 0 # no compression | ||
|
||
- name: Test CPython typing test suite | ||
# Test suite fails on PyPy even without typing_extensions | ||
if: ${{ !startsWith(matrix.python-version, 'pypy') }} | ||
|
@@ -109,3 +135,62 @@ jobs: | |
title: `Daily tests failed on ${new Date().toDateString()}`, | ||
body: "Runs listed here: https://github.com/python/typing_extensions/actions/workflows/ci.yml", | ||
}) | ||
|
||
report-coverage: | ||
name: Report coverage | ||
|
||
runs-on: ubuntu-latest | ||
|
||
needs: [tests] | ||
permissions: | ||
contents: read | ||
pull-requests: write | ||
|
||
if: ${{ always() }} | ||
JelleZijlstra marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3" | ||
- name: Download coverage artifacts | ||
uses: actions/download-artifact@v4 | ||
with: | ||
pattern: .coverage_* | ||
path: . | ||
# merge only when files are named differently | ||
merge-multiple: true | ||
- name: Install dependencies | ||
run: pip install coverage | ||
- name: Combine coverage results | ||
run: | | ||
# List the files to see what we have | ||
echo "Combining coverage files..." | ||
ls -aR .coverage* | ||
coverage combine .coverage* | ||
# add -i to ignore code in ephemeral python files created in temporary | ||
# directories during tests; this will result in warnings in the report | ||
echo "Creating coverage report..." | ||
coverage report | ||
coverage xml | ||
|
||
- name: Code Coverage Report | ||
uses: irongut/[email protected] | ||
with: | ||
filename: coverage.xml | ||
badge: true | ||
fail_below_min: false | ||
format: markdown | ||
hide_branch_rate: false | ||
hide_complexity: true | ||
indicators: true | ||
output: both | ||
thresholds: '80 90' | ||
|
||
- name: Add Coverage PR Comment | ||
uses: marocchino/sticky-pull-request-comment@v2 | ||
if: github.event_name == 'pull_request' | ||
with: | ||
recreate: true | ||
path: code-coverage-results.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,6 @@ venv*/ | |
*.swp | ||
*.pyc | ||
*.egg-info/ | ||
|
||
.coverage* | ||
coverage.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.