Use PEP 661 Sentinel for internal sentinel
#657
Merged
+36
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, incidentally the It's last use (and it's global instance) were removed in python/cpython#136332 |
|
Opened python/cpython#138120 |
JelleZijlstra
approved these changes
Aug 24, 2025
|
Let's merge this after the non-RC release goes out tomorrow. |
|
Hmm, would we revert if PEP 661 was rejected? |
|
If so, we'd likely keep Sentinel around in typing-extensions indefinitely for compatibility, and there's no real compatibility problem with changing this internal sentinel back to an internal class. |
AlexWaygood
reviewed
Aug 25, 2025
Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐶
c.f. #656 (comment)